Extract reusable build workflow#211
Closed
leynos wants to merge 1 commit into
Closed
Conversation
Deduplicate release job logic into a reusable workflow used across Linux, Windows, and macOS builds.
Contributor
Reviewer's GuideThis PR extracts the per-platform build and packaging logic into a single reusable workflow and refactors release.yml to invoke it for Linux, Windows, and macOS, significantly reducing duplication and centralizing CI steps. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
|
@coderabbitai pause |
Contributor
|
Note Reviews pausedUse the following commands to manage reviews:
|
Contributor
✅ Actions performedReviews paused. |
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and found some issues that need to be addressed.
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/build-and-package.yml:64` </location>
<code_context>
- target: aarch64-unknown-linux-gnu
artifact: linux-arm64
package_arch: arm64
- steps:
- - uses: >-
- actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
</code_context>
<issue_to_address>
**issue (review_instructions):** Add behavioural and unit tests for the new build-and-package workflow logic.
This workflow introduces new logic for cross-platform build and packaging. You must provide both behavioural and unit tests to demonstrate that the workflow functions as intended and handles expected scenarios.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `**/*`
**Instructions:**
For any new feature or change to an existing feature, both behavioural *and* unit tests are required.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f02eb907e48322b793bac1a3f97686
Summary by Sourcery
Extract common build and packaging steps into a reusable workflow and update the release pipeline to call it for Linux, Windows, and macOS builds.
New Features:
Enhancements:
Build:
CI: